CMake

A place to discuss everything related to Newton Dynamics.

Moderators: Sascha Willems, walaber

Re: CMake

Postby Julio Jerez » Fri Oct 26, 2018 1:38 pm

ah cool, make sure you sync so that you get the latest changes I commit this morning,

I will not make more until you upload the next archive.
also when you make the changes, the is not need to keep the code you changed commented out.
you can just delete it.
Julio Jerez
Moderator
Moderator
 
Posts: 11039
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles

Re: CMake

Postby arpio » Fri Oct 26, 2018 1:46 pm

Ok. Would just need to know what to do with the headers? All in separate directory?
arpio
 
Posts: 23
Joined: Wed Oct 24, 2018 4:33 pm

Re: CMake

Postby Julio Jerez » Fri Oct 26, 2018 2:23 pm

I thought something like this was fine, a build root, and under build the folder name that hiouse the header, in the source directory. It just that it missed some libraries like slick said.
Untitled.png
Untitled.png (5.9 KiB) Viewed 1678 times
Julio Jerez
Moderator
Moderator
 
Posts: 11039
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles

Re: CMake

Postby arpio » Fri Oct 26, 2018 4:51 pm

Here is an update, please test on windows with a clean sources. It is working on Linux with the Latest commit d89a8ce.

Also test the demos I'm not sure if they work on Windows.

@Julio
To get the demos compile on Linux still need some changes:

//DemoEntityManager.cpp
Line 576: GetModuleFileNameA(NULL, plugInPath, 256);

to:
#if defined (_WIN_32_VER) || defined (_WIN_64_VER)
GetModuleFileNameA(NULL, plugInPath, 256);
#endif

also the default scene is defined at line 70, it craches on linux. Can you just switch the default scene to scene 0 at line 34. This way the sandbox demo will start.

//StandardJoints.cpp
Line 1095: m_coneAngle = min(maxAng, coneAngle);
Line 1096: dFloat angle = max(0.0f, min(maxAng, arcAngle + m_coneAngle) - m_coneAngle);

to:
#if (defined (_POSIX_VER_64) || (_POSIX_VER))
m_coneAngle = fmin(maxAng, coneAngle);
dFloat angle = fmax(0.0f, fmin(maxAng, arcAngle + m_coneAngle) - m_coneAngle);
#else
m_coneAngle = min(maxAng, coneAngle);
dFloat angle = max(0.0f, min(maxAng, arcAngle + m_coneAngle) - m_coneAngle);
#endif
Attachments
newton-dynamics.zip
Cmake Changes
(52.35 KiB) Downloaded 89 times
arpio
 
Posts: 23
Joined: Wed Oct 24, 2018 4:33 pm

Re: CMake

Postby Julio Jerez » Fri Oct 26, 2018 5:05 pm

ok I fixed the cpp compatibility issues, I merge the script later.
Julio Jerez
Moderator
Moderator
 
Posts: 11039
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles

Re: CMake

Postby arpio » Fri Oct 26, 2018 7:34 pm

Just wait with merging. Still some issues at least linux part. Working on it.
arpio
 
Posts: 23
Joined: Wed Oct 24, 2018 4:33 pm

Re: CMake

Postby arpio » Fri Oct 26, 2018 8:38 pm

I hope it is good now if no issues on windows.

The only what I noticed there is no gravity in the demos. Is it still cmake related or just Linux?
Attachments
newton-dynamics.zip
(52.3 KiB) Downloaded 93 times
arpio
 
Posts: 23
Joined: Wed Oct 24, 2018 4:33 pm

Re: CMake

Postby Julio Jerez » Sat Oct 27, 2018 9:38 am

ok I merged it and afte fixing the precompile header problem is all works very well.

Later I will make a small change to the window build so that in place the install under a "build" folder
but othe than tha is very, very cool and much more clever than my version.

Thank you,

about the gravity thing, is a work in progress on the vehicle than I am debugging, it will be fixed soon.
Julio Jerez
Moderator
Moderator
 
Posts: 11039
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles

Re: CMake

Postby Slick » Sat Nov 03, 2018 10:25 am

I did a complete refresh today and the CMake script is good on Windows.

One missing thing is that the headers for dgNewton are not copied to the build\include folder.
Slick
 
Posts: 266
Joined: Sat Feb 07, 2004 7:24 pm
Location: Los Angeles

Re: CMake

Postby Julio Jerez » Sat Nov 03, 2018 3:02 pm

the is not dgNewton, that's only the name of the source directory, the file are installed in the newton folder. I know is an inconsistency, one should probably change but I am not doing that.
Julio Jerez
Moderator
Moderator
 
Posts: 11039
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles

Previous

Return to General Discussion

Who is online

Users browsing this forum: No registered users and 2 guests

cron