Assert In the Broadphase [SOLVED]

Report any bugs here and we'll post fixes

Moderators: Sascha Willems, Thomas

Assert In the Broadphase [SOLVED]

Postby MeltingPlastic » Thu Sep 13, 2018 12:17 pm

Hi Julio,

I am getting
Code: Select all
dgAssert (filter.Insert(0, dgKey(contactNode->GetInfo())));

in dgBroadPhase.cpp line 1700

It comes up seemingly randomly. sometimes it does not come up at all. I am only dealing with simple rigid bodies and no joints.

https://drive.google.com/open?id=1F4co8Xqb4pn-y88BJS_2_Zo8BWt6hJKM

I am on commit: ace2116e60c0c119ebaa06a4a201b21d149dae25 (9/13/2018)

Thanks!
Last edited by MeltingPlastic on Fri Sep 28, 2018 1:49 pm, edited 1 time in total.
MeltingPlastic
 
Posts: 237
Joined: Fri Feb 07, 2014 11:30 pm

Re: Assert In the Broadphase

Postby Julio Jerez » Thu Sep 13, 2018 1:29 pm

oh very cool you found that.
yes I added that check to see how often two different threads were going to find the same new pair.

the reason is that if the event is rare, then is better to let it happens, and them remove the duplicate from the cached list.
if it is very frequent then a critical section is required to add pairs to the cached list and that's a less desirable option.

your finding shows the first option is best.

I will fix that this weekend alone with those other asserts you has reported.

this is what makes an engine stronger more than anything else.
thank you for that.
Julio Jerez
Moderator
Moderator
 
Posts: 12249
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles

Re: Assert In the Broadphase

Postby MeltingPlastic » Thu Sep 13, 2018 2:40 pm

No problem!
MeltingPlastic
 
Posts: 237
Joined: Fri Feb 07, 2014 11:30 pm

Re: Assert In the Broadphase

Postby Julio Jerez » Sat Sep 22, 2018 8:00 pm

Ok I have this fixed now.
please sync and try again
Julio Jerez
Moderator
Moderator
 
Posts: 12249
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles


Return to Bugs and Fixes

Who is online

Users browsing this forum: No registered users and 6 guests