dgWorld::m_islandMemory alignment bug

Report any bugs here and we'll post fixes

Moderators: Sascha Willems, Thomas

dgWorld::m_islandMemory alignment bug

Postby Cannos » Fri Nov 11, 2016 12:02 am

The dgWorld::m_islandMemory array is aligned to 32 bytes (dgWorld.cpp, line 238), but 64-bit versions of Newton require at least 64 byte alignment (DG_MEMORY_GRANULARITY==64 for those). This is causing asserts and crashes for 64-bit versions. I locally changed that to 64 like all the other arrays in dgWorld and it fixed my issues.

It's a really simple change, it will take longer to merge a pull request than to make it directly. But I'm more than happy to check it in and do a pull request if you like. Thanks!
Cannos
 
Posts: 129
Joined: Thu Mar 04, 2010 5:41 pm

Re: dgWorld::m_islandMemory alignment bug

Postby Julio Jerez » Fri Nov 11, 2016 1:29 am

Oh thank, yes that one change I made recently and I made the aligment 32 bytes, but you are right is should be 64 like the others, I will fix right away.
Julio Jerez
Moderator
Moderator
 
Posts: 11039
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles


Return to Bugs and Fixes

Who is online

Users browsing this forum: No registered users and 1 guest

cron