Problem in the Linux build (fix attached)

Report any bugs here and we'll post fixes

Moderators: Sascha Willems, Thomas

Problem in the Linux build (fix attached)

Postby godlike » Mon May 11, 2015 4:12 pm

Hi,

Pulled the latest revision of Newton and tried to build on my machine with Ubuntu 14.04. Unfortunately there are multiple failures.
- It seems the SSE4 include header is not actually included (smmintrin.h)
- The -msse4 is missing from the compiler args
- For some reason wxWidgets that my system has installed (ver 3.x) complains about the C++ standard. So I added -std=c++11 to the demosSandbox/CMakeLists.txt

Patch that fixed my build here: http://ancient-ritual.com/tmp/fix_linux_build.diff

PS: The forum doesn't allow uploading .diff or .patch or .txt files
User avatar
godlike
 
Posts: 58
Joined: Sun Mar 16, 2014 3:48 am

Re: Problem in the Linux build (fix attached)

Postby Julio Jerez » Tue May 12, 2015 2:00 am

Ok I the patch failed by I applied manually. please see if it works.
Julio Jerez
Moderator
Moderator
 
Posts: 11046
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles

Re: Problem in the Linux build (fix attached)

Postby godlike » Tue May 12, 2015 2:37 am

Thanks Julio, it worked fine
User avatar
godlike
 
Posts: 58
Joined: Sun Mar 16, 2014 3:48 am

Re: Problem in the Linux build (fix attached)

Postby aitzolmuelas » Tue May 12, 2015 4:40 am

To be fully coherent with the current defines, maybe the SSE4 include (smmintrin.h) should be ifdefed with DG_SSE4_INSTRUCTIONS_SET:
Code: Select all
#ifdef DG_SSE4_INSTRUCTIONS_SET
  #include <smmintrin.h>
#endif
aitzolmuelas
 
Posts: 78
Joined: Wed Mar 25, 2015 1:10 pm

Re: Problem in the Linux build (fix attached)

Postby godlike » Tue May 12, 2015 7:03 am

aitzolmuelas wrote:To be fully coherent with the current defines, maybe the SSE4 include (smmintrin.h) should be ifdefed with DG_SSE4_INSTRUCTIONS_SET:
Code: Select all
#ifdef DG_SSE4_INSTRUCTIONS_SET
  #include <smmintrin.h>
#endif


I think Julio mentioned somewhere that he is planning to drop SSE prior to ver 4. So, it's going to be SSE4.x or no-SSE. Anyway, this part of dgTypes.h probably needs some cleaning because the SSE headers are guarded by this:

Code: Select all
#if (defined (_POSIX_VER) || defined (_POSIX_VER_64) || defined (_MINGW_32_VER) || defined (_MINGW_64_VER))


and this doesn't take into account the DG_SCALAR_VECTOR_CLASS or something related to SIMD
User avatar
godlike
 
Posts: 58
Joined: Sun Mar 16, 2014 3:48 am

Re: Problem in the Linux build (fix attached)

Postby Julio Jerez » Tue May 12, 2015 10:12 am

ha yes, done. I said I will not do AVX coding, not sse.
Julio Jerez
Moderator
Moderator
 
Posts: 11046
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles


Return to Bugs and Fixes

Who is online

Users browsing this forum: No registered users and 1 guest

cron